Making everything use a single structure #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I be opening these pull requests to my own branch or the main branch? |
directly to main is fine! but now it's pointing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I wasn't able to remove the Manifest.toml in the other pull request, so I closed that one and have opened a new. Same thing as before, I modified functions to run on a single structure, removed the redundant functions, and now also removed the Manifest.toml. I believe everything should work as it did before.
I haven't yet included the checkpointed time integration because I want to see if I can get it to work on my own computer with the modified package before adding it completely (so I'll run
using ShallowWatersand see if that's enough to then run the checkpointed problem, I think it should be). This will also let me try everything with the new version of Enzyme, which theoretically sped up compile times